Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing perms to sql_lab role #4714

Merged
merged 1 commit into from
Mar 29, 2018

Conversation

mistercrunch
Copy link
Member

The SQL Lab related role that is created programmatically is missing
permissions that make SQL Lab functional.

@hughhhh
Copy link
Member

hughhhh commented Mar 29, 2018

🚢

The SQL Lab related role that is created programmatically is missing
permissions that make SQL Lab functional.
@codecov-io
Copy link

Codecov Report

Merging #4714 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4714   +/-   ##
=======================================
  Coverage   71.87%   71.87%           
=======================================
  Files         204      204           
  Lines       15323    15323           
  Branches     1177     1177           
=======================================
  Hits        11014    11014           
  Misses       4306     4306           
  Partials        3        3
Impacted Files Coverage Δ
superset/security.py 74.21% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f952ec2...297300f. Read the comment docs.

@mistercrunch mistercrunch merged commit 9ee78d1 into apache:master Mar 29, 2018
@mistercrunch mistercrunch deleted the fix_sqllab_perms branch March 29, 2018 21:24
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
The SQL Lab related role that is created programmatically is missing
permissions that make SQL Lab functional.
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
The SQL Lab related role that is created programmatically is missing
permissions that make SQL Lab functional.
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants