Add missing perms to sql_lab role

The SQL Lab related role that is created programmatically is missing permissions that make SQL Lab functional.
apache · Mar 29, 2018 · 297300f · 297300f
1 parent 68dec24
commit 297300f
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/superset/security.py b/superset/security.py
@@ -349,9 +349,14 @@ def is_gamma_pvm(self, pvm):
                     self.is_alpha_only(pvm))
 
     def is_sql_lab_pvm(self, pvm):
-        return pvm.view_menu.name in {'SQL Lab'} or pvm.permission.name in {
-            'can_sql_json', 'can_csv', 'can_search_queries',
-        }
+        return (
+            pvm.view_menu.name in {
+                'SQL Lab', 'SQL Editor', 'Query Search', 'Saved Queries',
+            } or
+            pvm.permission.name in {
+                'can_sql_json', 'can_csv', 'can_search_queries', 'can_sqllab_viz',
+                'can_sqllab',
+            })
 
     def is_granter_pvm(self, pvm):
         return pvm.permission.name in {