[dashboards] Increasing position_json to MEDIUMTEXT for MySQL #5618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| def MediumText(): | ||
| return Text().with_variant(MEDIUMTEXT(), 'mysql') |
There was a problem hiding this comment.
oh nice! SQLAlchemy keeps on revealing its secrets :)
john-bodley
force-pushed
the
john-bodley-position-json-medium-text
branch
from
21f41cf
to
eec969f
Compare
Codecov Report
@@ Coverage Diff @@
## master #5618 +/- ##
==========================================
+ Coverage 63.62% 63.62% +<.01%
==========================================
Files 359 359
Lines 22823 22827 +4
Branches 2534 2534
==========================================
+ Hits 14520 14524 +4
Misses 8288 8288
Partials 15 15
Continue to review full report at Codecov.
|
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
9 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most SQLA engines are unbounded for the
TEXTtype however for MySQL it's restricted to ~ 64 kB which can cause overflow for thedashboards.position_jsoncolumn for the V2 layout.This PR ensures that for MySQL engines the
TEXTcolumn is changed fromTEXT(~ 64 kB) toMEDIUMTEXT(~ 16 MB). All other engines remained unchanged.to: @graceguo-supercat @michellethomas @mistercrunch @williaster