-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dashboards] Increasing position_json to MEDIUMTEXT for MySQL #5618
[dashboards] Increasing position_json to MEDIUMTEXT for MySQL #5618
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
|
||
|
||
def MediumText(): | ||
return Text().with_variant(MEDIUMTEXT(), 'mysql') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh nice! SQLAlchemy keeps on revealing its secrets :)
21f41cf
to
eec969f
Compare
Codecov Report
@@ Coverage Diff @@
## master #5618 +/- ##
==========================================
+ Coverage 63.62% 63.62% +<.01%
==========================================
Files 359 359
Lines 22823 22827 +4
Branches 2534 2534
==========================================
+ Hits 14520 14524 +4
Misses 8288 8288
Partials 15 15
Continue to review full report at Codecov.
|
Most SQLA engines are unbounded for the
TEXT
type however for MySQL it's restricted to ~ 64 kB which can cause overflow for thedashboards.position_json
column for the V2 layout.This PR ensures that for MySQL engines the
TEXT
column is changed fromTEXT
(~ 64 kB) toMEDIUMTEXT
(~ 16 MB). All other engines remained unchanged.to: @graceguo-supercat @michellethomas @mistercrunch @williaster