handle exception and set dtype value to JSON, when column type JSON #5644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mistercrunch PTAL |
Codecov Report
@@ Coverage Diff @@
## master #5644 +/- ##
==========================================
- Coverage 63.51% 63.51% -0.01%
==========================================
Files 360 360
Lines 22890 22891 +1
Branches 2549 2549
==========================================
Hits 14539 14539
- Misses 8336 8337 +1
Partials 15 15
Continue to review full report at Codecov.
|
superset/views/core.py
Outdated
| @@ -2252,6 +2252,8 @@ def table(self, database_id, table_name, schema): | |||
| try: | |||
| dtype = '{}'.format(col['type']) | |||
| except Exception: | |||
| if isinstance(col['type'], sqla.types.JSON): | |||
There was a problem hiding this comment.
let's do more generic error handling here dtype = col['type'].__class__.__name__
added 2 commits
August 16, 2018 11:13
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 21, 2018
…pache#5644) * handle exception and set dtype value to JSON, when column type JSON * review comment * only when we handle exception (cherry picked from commit cc9324a)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 22, 2018
…pache#5644) * handle exception and set dtype value to JSON, when column type JSON * review comment * only when we handle exception (cherry picked from commit cc9324a)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 22, 2018
…pache#5644) * handle exception and set dtype value to JSON, when column type JSON * review comment * only when we handle exception (cherry picked from commit cc9324a)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
…pache#5644) * handle exception and set dtype value to JSON, when column type JSON * review comment * only when we handle exception
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we pass the exception for sqlachemy.types.JSON type, in the UI when we list columns in the table we do not show the correct type.
ERROR:root:Compiler <sqlalchemy.sql.compiler.GenericTypeCompiler object at 0x7fc5aa6cad90> can't render element of type <class 'sqlalchemy.sql.sqltypes.JSON'>