Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle exception and set dtype value to JSON, when column type JSON #5644

Merged
merged 3 commits into from
Aug 17, 2018
Merged

handle exception and set dtype value to JSON, when column type JSON #5644

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09ccaff
handle exception and set dtype value to JSON, when column type JSON
Aug 16, 2018
030d97f
review comment
Aug 16, 2018
6c2e9be
only when we handle exception
Aug 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions superset/views/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2252,6 +2252,8 @@ def table(self, database_id, table_name, schema):
try:
dtype = '{}'.format(col['type'])
except Exception:
if isinstance(col['type'], sqla.types.JSON):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do more generic error handling here dtype = col['type'].__class__.__name__

dtype = 'JSON'
pass
payload_columns.append({
'name': col['name'],
Expand Down