[SIP-5] Repair and refactor Horizon Chart #5690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5690 +/- ##
==========================================
+ Coverage 63.43% 63.51% +0.08%
==========================================
Files 361 362 +1
Lines 22977 22947 -30
Branches 2558 2550 -8
==========================================
Hits 14575 14575
+ Misses 8387 8357 -30
Partials 15 15
Continue to review full report at Codecov.
|
williaster
approved these changes
Aug 23, 2018
| choices: [ | ||
| ['series', 'series'], | ||
| ['overall', 'overall'], | ||
| ['change', 'change'], | ||
| ], | ||
| default: 'series', | ||
| description: t('Defines how the color are attributed.'), | ||
| description: t('series: Treat each series independently; overall: All series use the same scale; change: Show changes compared to the first data point in each series'), |
| className: '', | ||
| width: 800, | ||
| height: 20, | ||
| bands: DEFAULT_COLORS.length >> 1, |
There was a problem hiding this comment.
any way to write this without bitwise operators for readability? like Math.floor(DEFAULT_COLORS.length / 2) or something?
kristw
changed the title
|
Ready to merge |
williaster
approved these changes
Aug 27, 2018
kristw
added a commit
to kristw/incubator-superset
that referenced
this pull request
Aug 27, 2018
* Migrate horizon chart to react * remove unused code * rename files * update props * enable renderTrigger * fix canvas transform issue * Address Chris' comment (cherry picked from commit d7f06cb)
kristw
added a commit
to kristw/incubator-superset
that referenced
this pull request
Aug 27, 2018
* Migrate horizon chart to react * remove unused code * rename files * update props * enable renderTrigger * fix canvas transform issue * Address Chris' comment (cherry picked from commit d7f06cb)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* Migrate horizon chart to react * remove unused code * rename files * update props * enable renderTrigger * fix canvas transform issue * Address Chris' comment
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Migrate horizon chart to react * remove unused code * rename files * update props * enable renderTrigger * fix canvas transform issue * Address Chris' comment
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
renderTriggeron compatible propsBefore
After
@williaster @conglei