Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused functions and jquery dependency #5868

Merged
merged 2 commits into from
Sep 18, 2018

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Sep 12, 2018

Functions get, find and show are not used any more after the SIP-5 refactor.

@williaster @conglei @graceguo-supercat

@kristw kristw closed this Sep 12, 2018
@kristw kristw reopened this Sep 12, 2018
Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kristw
Copy link
Contributor Author

kristw commented Sep 13, 2018

Needs to wait for nvd3 PR

@conglei
Copy link
Contributor

conglei commented Sep 13, 2018

@kristw will review the nvd3 pr tmr !

@kristw kristw closed this Sep 18, 2018
@kristw kristw reopened this Sep 18, 2018
@williaster williaster merged commit f2d6449 into apache:master Sep 18, 2018
@kristw kristw deleted the kristw-remove-fn branch September 20, 2018 21:52
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
* remove unused functions and jquery dependency

* rebase and remove more obsolete functions
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants