Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused functions and jquery dependency #5868

Merged
merged 2 commits into from
Sep 18, 2018
Merged

Remove unused functions and jquery dependency #5868

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d11fe26
remove unused functions and jquery dependency
kristw Sep 12, 2018
13e73cc
rebase and remove more obsolete functions
kristw Sep 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions superset/assets/src/chart/ChartBody.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import React from 'react';
import PropTypes from 'prop-types';
import $ from 'jquery';

const propTypes = {
containerId: PropTypes.string.isRequired,
Expand All @@ -11,26 +10,6 @@ const propTypes = {
};

class ChartBody extends React.PureComponent {
html(data) {
this.el.innerHTML = data;
}

css(property, value) {
this.el.style[property] = value;
}

get(n) {
return $(this.el).get(n);
}

find(classname) {
return $(this.el).find(classname);
}

show() {
return $(this.el).show();
}

height() {
return this.props.height();
}
Expand Down