[bugfix] don't parse save dashboard response #6349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michellethomas
approved these changes
Nov 9, 2018
Codecov Report
@@ Coverage Diff @@
## master #6349 +/- ##
=======================================
Coverage 77.33% 77.33%
=======================================
Files 67 67
Lines 9578 9578
=======================================
Hits 7407 7407
Misses 2171 2171Continue to review full report at Codecov.
|
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
Nov 9, 2018
* [bugfix] don't parse save dashboard response * [dashboard] remove bracket in error message (cherry picked from commit 62dcce8)
bipinsoniguavus
pushed a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Dec 26, 2018
* [bugfix] don't parse save dashboard response * [dashboard] remove bracket in error message
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now a straight
saveon a dashboard displays an error message in the UI (tho the save is successful) because the success response is not JSON, which is the defaultparseMethodforSupersetClientThis also removes an extra bracket shown in the error message when there is an error saving.
Verified locally.
@michellethomas @graceguo-supercat @kristw @mistercrunch