[dashboard] fix save/save-as flow #6350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6350 +/- ##
=======================================
Coverage 77.33% 77.33%
=======================================
Files 67 67
Lines 9578 9578
=======================================
Hits 7407 7407
Misses 2171 2171
Continue to review full report at Codecov.
|
michellethomas
approved these changes
Nov 9, 2018
kristw
pushed a commit
to kristw/incubator-superset
that referenced
this pull request
Nov 9, 2018
* [dashboard] fix save/save-as flow * [bugfix][dashboard] consistent response type for save/save-as (cherry picked from commit 8bf9a5b)
bipinsoniguavus
pushed a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Dec 26, 2018
* [dashboard] fix save/save-as flow * [bugfix][dashboard] consistent response type for save/save-as
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously #6189 fixed a dashboard
save asredirect bug, but introduced a dashboardsavebug which was fixed today by #6349. However fixing thesavebug re-introduced thesave asbug 🙉Basically
save-asreturns the newidfor the redirect asjson, butsavereturnsHTMLwhich throws if you parse it asjson🙄Putting the two together,this PR keepsparseMethod: null, and handles the json parsing within thesave-ashandler.EDIT: updated to just make the return type consistent (
json) and always parse asjson.Tested BOTH locally.
@michellethomas @graceguo-supercat @kristw @mistercrunch