[dashboard][bugfix][save as] re-direct to copied dashboard upon saveas #6189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristw
reviewed
Oct 25, 2018
| t('Could not fetch all saved charts'), | ||
| .catch(errorResponse => | ||
| getClientErrorObject(errorResponse).then(({ error }) => | ||
| Promise.all([ |
There was a problem hiding this comment.
Promise.all seems unnecessary.
Is anybody expecting the result from the dispatches?
Might be better to return the errorObject, or don't care about return value at all.
.catch(errorResponse =>
getClientErrorObject(errorResponse).then(({ error }) => {
dispatch(...);
dispatch(...);
});.catch(errorResponse => {
const errorObjectPromise = getClientErrorObject(errorResponse);
errorObject.then(({ error }) => {
dispatch(...);
dispatch(...);
});
return errorObjectPromise;
}
There was a problem hiding this comment.
return is necessary over here. redirecting is depends on new dash id in the response.
kristw
approved these changes
Oct 25, 2018
Codecov Report
@@ Coverage Diff @@
## master #6189 +/- ##
=======================================
Coverage 76.93% 76.93%
=======================================
Files 47 47
Lines 9386 9386
=======================================
Hits 7221 7221
Misses 2165 2165Continue to review full report at Codecov.
|
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
Oct 25, 2018
apache#6189) * [dashboard][bugfix][save as] re-direct to copied dashboard upon saveas * [dashboard][save modal] safer destructuring * [dashboard][save as] simplify Promise resolution * [dashboard] simply fetch slices error (cherry picked from commit e7e8e9d)
bipinsoniguavus
pushed a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Dec 26, 2018
apache#6189) * [dashboard][bugfix][save as] re-direct to copied dashboard upon saveas * [dashboard][save modal] safer destructuring * [dashboard][save as] simplify Promise resolution * [dashboard] simply fetch slices error
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Fixes #6188 where you are not re-directed upon copying a dashboard. Introduced by this line in the SupersetClient refactor 🙄
after fix
@graceguo-supercat @kristw @michellethomas