Update dependency downloader #4
Conversation
chipsenkbeil
force-pushed
the
UpdateDependencyDownloader
branch
from
d66bed0
to
116d8bc
Compare
|
taking a look at this now |
|
Tried a couple of dependencies and different repositories and all worked fine. I saw that dependencies are getting installed under |
|
Potential JIRAs that can be resolved by this |
| )*/ | ||
| val dependencyDownloader = new CoursierDependencyDownloader | ||
| dependencyDownloader.setDownloadDirectory( | ||
| new File(config.getString("ivy_local")) |
There was a problem hiding this comment.
If we change this to something else, we could avoid clashes between kernel instances. Or, if we set the default ivy_local to a temporary directory, that would work as well.
|
Do we want to look into this under the same PR? Or open another issue? https://issues.apache.org/jira/browse/TOREE-169?focusedCommentId=15104588&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15104588 |
|
FYI, I read that using Coursier for resolution/downloading over standard sbt has a large increase in performance. Might be worth adding the plugin for us to see if it helps with Toree dependency resolution/downloading, especially when running automated build/test. |
|
Lets handle the location of the deps in a separate PR. I opened https://issues.apache.org/jira/browse/TOREE-261. We should just go ahead and get that work done asap since this is fresh. |
Adds the following options to %AddDeps:
--repository <URL>to include another repository when downloading--traceto print out download information--verboseto print out miscellaneous informationThese options will show up in the help menu. You can provide
--repositorymore than once to include more than one additional repository.Will ignore any malformed URL. Will try repositories provided by
--repositoryfirst before default repositories.