-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Conversation
…s) converting method.
…nceId Keep The Same With Others
# Conflicts: # ios/sdk/WeexSDK.xcodeproj/project.pbxproj
# Conflicts: # ios/sdk/WeexSDK.xcodeproj/project.pbxproj # ios/sdk/WeexSDK/Sources/Utility/WXVersion.m
# Conflicts: # android/playground/app/build.gradle # android/playground/app/src/main/java/com/alibaba/weex/WXApplication.java # android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java
Generated by 🚫 dangerJS |
} | ||
}); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't delete, use for preinit
@@ -1493,11 +1480,13 @@ public void run() { | |||
} | |||
|
|||
WXModuleManager.createDomModule(instance); | |||
instance.getApmForInstance().onStage(WXInstanceApm.KEY_PAGE_STAGES_LOAD_BUNDLE_START); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't mv position
post(new Runnable() { | ||
@Override | ||
public void run() { | ||
long start = System.currentTimeMillis(); | ||
instance.getApmForInstance().onStage(WXInstanceApm.KEY_PAGE_STAGES_LOAD_BUNDLE_START); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't mv position,mv back
@@ -861,7 +869,6 @@ private void renderInternal(String pageName, | |||
} | |||
if (isPreInitMode()){ | |||
getApmForInstance().onStage(WXInstanceApm.KEY_PAGE_STAGES_LOAD_BUNDLE_START); | |||
WXBridgeManager.getInstance().loadJsBundleInPreInitMode(getInstanceId(),template.getContent()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't remove for preinit mode
@@ -1519,6 +1532,9 @@ public void onViewAppear(){ | |||
|
|||
|
|||
public void onCreateFinish() { | |||
if(mHasCreateFinish){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will cause onViewAppear
never invoked
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
heron-merge