This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
[Android] bugfix of the scrollstart and scrollend event mismatching #2638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
YorkShen
suggested changes
Jul 2, 2019
| @@ -64,14 +67,16 @@ public void onScrolled(int x, int y){ | |||
| || component.getEvents().contains(Constants.Event.SCROLL_END))){ | |||
| this.x = x; | |||
| this.y = y; | |||
| if(!hasStart){ | |||
| if(!hasStart && canStart){ | |||
There was a problem hiding this comment.
This if block from line 75 to 79 should be deleted as code in line 95 fired the event.
There was a problem hiding this comment.
code inline 95 is for the case the list has reached the top or bottom that can not callback in onscroll
There was a problem hiding this comment.
Actually, you can safely delete code from line 95 to line 98, which are never invoked in any case.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Android] bugfix of the scrollstart and scrollend event mismatching