-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INLONG-9788][Sort] Supports data parse that contains delimiters in kv and csv data format #9789
Conversation
baomingyu
commented
Mar 7, 2024
- Fixes [Feature][Sort] Supports data parse that contains delimiters in kv and csv data content #9788
…v and csv data content
...ort-formats/format-common/src/main/java/org/apache/inlong/sort/formats/util/StringUtils.java
Outdated
Show resolved
Hide resolved
...rmats/format-common/src/test/java/org/apache/inlong/sort/formats/common/StringUtilsTest.java
Show resolved
Hide resolved
I found that we already have several tests for Is it necessacery to add a new test class? |
All existing tests are tests of data in kv and csv formats that combine expected rules. The new ones are scenarios that can parse data in kv and csv formats that do not comply with the rules. |
What I am concerned about is whether the new test cases can be added to the existing UT class(the three UT classes mentioned above) or not. Or, are there some reasons that we must put the new test cases into a new UT class? |
New tests test new scenarios,whether to put it in the inventory will be adjusted later. |
Make sense to me. We can unify the UT later. |