Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipe: support replace and modify mode for alter pipe sql #12018

Merged
merged 13 commits into from
Feb 6, 2024
Merged

Pipe: support replace and modify mode for alter pipe sql #12018

merged 13 commits into from
Feb 6, 2024

Conversation

VGalaxies
Copy link
Contributor

Description

As title.

This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.
Key changed/added classes (or packages if there are too many classes) in this PR

@SteveYurongSu SteveYurongSu self-assigned this Feb 2, 2024
Caideyipi
Caideyipi suggested changes Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@Caideyipi Caideyipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

integration-test/src/test/java/org/apache/iotdb/pipe/it/IoTDBPipeAlterIT.java Show resolved Hide resolved
integration-test/src/test/java/org/apache/iotdb/pipe/it/IoTDBPipeAlterIT.java Show resolved Hide resolved
...core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/pipe/PipeTaskInfo.java Outdated Show resolved Hide resolved
...pi/pipe-api/src/main/java/org/apache/iotdb/pipe/api/customizer/parameter/PipeParameters.java Outdated Show resolved Hide resolved
SteveYurongSu
SteveYurongSu approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@SteveYurongSu SteveYurongSu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greaaaaaaat

@SteveYurongSu SteveYurongSu merged commit fd4337e into apache:master Feb 6, 2024
36 checks passed
@VGalaxies VGalaxies deleted the alter-pipe-it branch February 6, 2024 07:03
SzyWilliam pushed a commit to SzyWilliam/iotdb that referenced this pull request Nov 26, 2024
@VGalaxies @SzyWilliam
Pipe: support replace and modify mode for alter pipe sql (apache#12018)
0f89f0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Caideyipi Caideyipi Caideyipi requested changes

@SteveYurongSu SteveYurongSu SteveYurongSu approved these changes

Assignees

@SteveYurongSu SteveYurongSu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VGalaxies @SteveYurongSu @Caideyipi