Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Ratis query not retrying when DataNode restarts #12029

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

OneSizeFitsQuorum
Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum commented Feb 5, 2024

img_v3_027m_4aefc1d2-8b82-464c-aaf9-20fb04a502cg
image

Retry the request for ServerNotReadyException

Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (6943524) 49.15% compared to head (b6e18e7) 49.15%.
Report is 3 commits behind head on master.

Files Patch % Lines
...a/org/apache/iotdb/jdbc/IoTDBDatabaseMetadata.java 11.11% 16 Missing ⚠️
...java/org/apache/iotdb/jdbc/IoTDBJDBCResultSet.java 0.00% 6 Missing ⚠️
...tatemachine/dataregion/DataRegionStateMachine.java 0.00% 4 Missing ⚠️
...gine/execution/executor/RegionExecutionResult.java 0.00% 3 Missing ⚠️
...plan/scheduler/FragmentInstanceDispatcherImpl.java 0.00% 2 Missing ⚠️
...ol/thrift/impl/DataNodeInternalRPCServiceImpl.java 0.00% 1 Missing ⚠️
...yengine/execution/executor/RegionReadExecutor.java 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12029      +/-   ##
============================================
- Coverage     49.15%   49.15%   -0.01%     
- Complexity    26156    26160       +4     
============================================
  Files          2943     2943              
  Lines        184519   184552      +33     
  Branches      22142    22152      +10     
============================================
+ Hits          90708    90721      +13     
- Misses        93811    93831      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HTHou HTHou merged commit 6e5605b into master Feb 5, 2024
36 of 37 checks passed
@HTHou HTHou deleted the ratis_linearizable_read branch February 6, 2024 01:36
SzyWilliam pushed a commit to SzyWilliam/iotdb that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants