Optimize flushing memtable check #12081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
shuwenwei
approved these changes
Feb 26, 2024
HTHou
added a commit
that referenced
this pull request
Mar 5, 2024
SzyWilliam
pushed a commit
to SzyWilliam/iotdb
that referenced
this pull request
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We found the flush submit task would stack a lot when write multiple time partitions concurrently.
The reason of this phenomenon is that the flush submit task check whether is the TsFileProcessor closing in the WriteLock of DataRegion. This check logic should be move out of the WriteLock.
Moreover, the closingSequenceTsFileProcessor and closingUnSequenceTsFileProcessor can be simplify to the HashSet instead.
After this modification, the write performance increased about 10%.