Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate point calculate because of consensus and so on #12459

Merged
merged 20 commits into from
May 30, 2024

Conversation

SpriCoder
Copy link
Contributor

Because we need to know the actual external writing point, I try to add isGenerateByConsensus parameters in PlanNode and try to remove duplicate points.

Copy link

codecov bot commented May 5, 2024

Codecov Report

Attention: Patch coverage is 63.79310% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 42.94%. Comparing base (a9c27bb) to head (bb8ecc6).
Report is 23 commits behind head on master.

Current head bb8ecc6 differs from pull request most recent head 86221ee

Please upload reports for the commit 86221ee to get more accurate results.

Files Patch % Lines
...ngine/plan/scheduler/load/LoadTsFileScheduler.java 0.00% 10 Missing ⚠️
...lanner/plan/node/write/InsertMultiTabletsNode.java 0.00% 3 Missing ⚠️
...e/plan/planner/plan/node/write/InsertRowsNode.java 0.00% 3 Missing ⚠️
...ner/plan/node/write/InsertRowsOfOneDeviceNode.java 0.00% 3 Missing ⚠️
...dataregion/IoTConsensusDataRegionStateMachine.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12459      +/-   ##
============================================
- Coverage     43.35%   42.94%   -0.42%     
  Complexity       69       69              
============================================
  Files          3166     3193      +27     
  Lines        196844   199181    +2337     
  Branches      23443    23745     +302     
============================================
+ Hits          85349    85540     +191     
- Misses       111495   113641    +2146     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SpriCoder
Copy link
Contributor Author

Test in IoTConsensus:
image

@SpriCoder
Copy link
Contributor Author

Test in Ratis Consensus:
image

@SpriCoder
Copy link
Contributor Author

Test on 1 node failed:
image

Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
11.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~
Awesome work!!!

@OneSizeFitsQuorum OneSizeFitsQuorum merged commit b231a1c into master May 30, 2024
35 of 38 checks passed
@OneSizeFitsQuorum OneSizeFitsQuorum deleted the feature/leader-write branch May 30, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants