-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate point calculate because of consensus and so on #12459
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12459 +/- ##
============================================
- Coverage 43.35% 42.94% -0.42%
Complexity 69 69
============================================
Files 3166 3193 +27
Lines 196844 199181 +2337
Branches 23443 23745 +302
============================================
+ Hits 85349 85540 +191
- Misses 111495 113641 +2146 ☔ View full report in Codecov by Sentry. |
...datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/load/LoadTsFileManager.java
Outdated
Show resolved
Hide resolved
.../datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/PlanNode.java
Outdated
Show resolved
Hide resolved
Quality Gate failedFailed conditions |
...e/consensus/src/main/java/org/apache/iotdb/consensus/ratis/ApplicationStateMachineProxy.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~
Awesome work!!!
Because we need to know the actual external writing point, I try to add
isGenerateByConsensus
parameters in PlanNode and try to remove duplicate points.