Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new data type: DATE, TIMESTAMP, BLOB and STRING #12576

Merged
merged 36 commits into from
May 28, 2024

Conversation

Cpaulyz
Copy link
Contributor

@Cpaulyz Cpaulyz commented May 23, 2024

Description

Support new data tye: DATE, TIMESTAMP, BLOB and STRING

@Cpaulyz Cpaulyz mentioned this pull request May 23, 2024
11 tasks
Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 24.68828% with 302 lines in your changes are missing coverage. Please review.

Project coverage is 43.09%. Comparing base (a8f3ca3) to head (c32c6fd).
Report is 4 commits behind head on master.

Current head c32c6fd differs from pull request most recent head 1f25051

Please upload reports for the commit 1f25051 to get more accurate results.

Files Patch % Lines
...execution/aggregation/MaxMinByBaseAccumulator.java 0.00% 30 Missing ⚠️
...e/iotdb/db/queryengine/plan/parser/ASTVisitor.java 10.00% 27 Missing ⚠️
...ine/execution/aggregation/MaxValueAccumulator.java 0.00% 23 Missing ⚠️
...ine/execution/aggregation/MinValueAccumulator.java 0.00% 23 Missing ⚠️
...ueryengine/plan/planner/OperatorTreeGenerator.java 8.33% 22 Missing ⚠️
...in/java/org/apache/iotdb/db/utils/CommonUtils.java 19.23% 21 Missing ⚠️
...ryengine/plan/statement/literal/BinaryLiteral.java 29.16% 17 Missing ⚠️
.../java/org/apache/iotdb/db/utils/DateTimeUtils.java 15.00% 17 Missing ⚠️
...va/org/apache/iotdb/session/util/SessionUtils.java 0.00% 14 Missing ⚠️
...rc/main/java/org/apache/iotdb/tool/ImportData.java 0.00% 13 Missing ⚠️
... and 36 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12576      +/-   ##
============================================
- Coverage     43.37%   43.09%   -0.28%     
  Complexity       69       69              
============================================
  Files          3166     3190      +24     
  Lines        196854   198293    +1439     
  Branches      23445    23613     +168     
============================================
+ Hits          85381    85450      +69     
- Misses       111473   112843    +1370     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cpaulyz Cpaulyz changed the title Support new data tye: DATE, TIMESTAMP, BLOB and STRING Support new data type: DATE, TIMESTAMP, BLOB and STRING May 24, 2024
Copy link

sonarcloud bot commented May 28, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
7.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@JackieTien97 JackieTien97 merged commit cb1bca6 into master May 28, 2024
57 of 58 checks passed
@JackieTien97 JackieTien97 deleted the new_data_type branch May 28, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants