Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipe: Added RemainingEventCount/EstimatedRemainingSeconds in configNode metrics/show pipes response #12578

Merged
merged 16 commits into from
May 29, 2024

Conversation

Caideyipi
Copy link
Collaborator

Description

As the title said.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@SteveYurongSu SteveYurongSu self-requested a review May 24, 2024 01:59
@SteveYurongSu SteveYurongSu self-assigned this May 24, 2024
@Caideyipi Caideyipi changed the title Pipe: Added RemainingEventCount/EstimatedRemainingSeconds in show pipes response Pipe: Added RemainingEventCount/EstimatedRemainingSeconds in metrics/show pipes response May 24, 2024
@Caideyipi Caideyipi changed the title Pipe: Added RemainingEventCount/EstimatedRemainingSeconds in metrics/show pipes response Pipe: Added RemainingEventCount/EstimatedRemainingSeconds in configNode metrics/show pipes response May 24, 2024
Caideyipi and others added 4 commits May 27, 2024 16:26
# Conflicts:
#	iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/service/metric/enums/Metric.java
Copy link
Member

@SteveYurongSu SteveYurongSu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: handle leader change / alter pipe

@SteveYurongSu SteveYurongSu merged commit bb728f0 into apache:master May 29, 2024
54 of 57 checks passed
SzyWilliam pushed a commit to SzyWilliam/iotdb that referenced this pull request Nov 26, 2024
…de metrics/show pipes response (apache#12578)

Co-authored-by: Steve Yurong Su <rong@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants