Fix/build issues outside of china #12600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…more robust to locale and time-zone differences.
JackieTien97
approved these changes
May 29, 2024
HTHou
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our testsuite doesn't pass when run on some systems with other Locale or TimeZone settings.
Mainly issues result from Locales like the German locale using "," for decimal separators instead of ".". Another problem causing issues, is that our long timestamps are GMT based and when running the tests in other timzeones, there can be differences. Therefore I've ensured the timezone is set to a chinese timezone when starting the server and ensured the Timzeone is set correctly for the tests that were causing problems.