Add or modify encryption related codes #13364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
jt2594838
approved these changes
Sep 2, 2024
integration-test/src/test/java/org/apache/iotdb/db/it/query/IoTDBEncryptionValueQueryIT.java
Outdated
Show resolved
Hide resolved
integration-test/src/test/java/org/apache/iotdb/db/it/query/IoTDBEncryptionValueQueryIT.java
Show resolved
Hide resolved
.../org/apache/iotdb/db/pipe/event/common/tsfile/container/scan/SinglePageWholeChunkReader.java
Outdated
Show resolved
Hide resolved
.../org/apache/iotdb/db/pipe/event/common/tsfile/container/scan/SinglePageWholeChunkReader.java
Outdated
Show resolved
Hide resolved
# Conflicts: # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/tsfile/parser/scan/TsFileInsertionEventScanParser.java # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/utils/executor/fast/reader/CompactionAlignedChunkReader.java # pom.xml
# Conflicts: # pom.xml
jt2594838
approved these changes
Oct 29, 2024
Comment on lines
+124
to
+127
| Path tempDir = Files.createTempDirectory(""); | ||
| tempDir.toFile().deleteOnExit(); | ||
| String tsfileName = | ||
| TsFileNameGenerator.generateNewTsFileName(System.currentTimeMillis(), 1, 0, 0); |
There was a problem hiding this comment.
Generally, all files generated in tests should be put under the "target" directory.
There was a problem hiding this comment.
I just do this like other tests which also need to generate tsfile. So I need to change the TempDirectory to "target"?
Comment on lines
+130
to
+132
| TSFileConfig config = TSFileDescriptor.getInstance().getConfig(); | ||
| config.setEncryptFlag("true"); | ||
| config.setEncryptType("org.apache.tsfile.encrypt.AES128"); |
There was a problem hiding this comment.
The configs should be rolled back after writing the file. (Maybe in the finally clause)
| ResultSet resultSet = statement.executeQuery("select s1 from root.testsg1.d1"); | ||
| Assert.fail(); | ||
| } catch (Exception e) { | ||
| System.out.println(e.getMessage()); |
jt2594838
approved these changes
Oct 29, 2024
VGalaxies
reviewed
Nov 6, 2024
...geengine/dataregion/compaction/execute/utils/executor/fast/reader/CompactionChunkReader.java
Outdated
Show resolved
Hide resolved
jt2594838
approved these changes
Nov 11, 2024
SteveYurongSu
approved these changes
Nov 12, 2024
...ava/org/apache/iotdb/db/pipe/event/common/tsfile/parser/scan/SinglePageWholeChunkReader.java
Outdated
Show resolved
Hide resolved
...org/apache/iotdb/db/pipe/event/common/tsfile/parser/scan/TsFileInsertionEventScanParser.java
Outdated
Show resolved
Hide resolved
SteveYurongSu
approved these changes
Nov 12, 2024
luoluoyuyu
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add or modify encryption related codes for encryption module realization.