Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sqlalchemy upper version constraint for python client #14083

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

MarcBresson
Copy link

@MarcBresson MarcBresson commented Nov 13, 2024

Description

There are only a few breaking changes listed in https://docs.sqlalchemy.org/en/20/changelog/migration_20.html#the-1-4-2-0-migration-path, and not is impacting this project.

Closes #13991


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this is your first pull request in IoTDB project. Thanks for your contribution! IoTDB will be better because of you.

@CritasWang
Copy link
Collaborator

@MarcBresson
Copy link
Author

FYI, the reason why I can't run the tests locally is because I have the following error : ModuleNotFoundError: No module named 'iotdb.thrift', that's why I need to do back and forth with the CI pipeline.

@HTHou
Copy link
Contributor

HTHou commented Nov 28, 2024

Hi, thanks for your work. It seems that the CI with sqlalchemy 2.0 finally works. However, the tests with sqlalchemy 1.4 failed. Is there any way we can support both 1.4 and 2.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] [Python] Allow for sqlalchemy versions greater tha 2.0
3 participants