-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sqlalchemy upper version constraint for python client #14083
base: master
Are you sure you want to change the base?
Conversation
there are only a few breaking changes listed in https://docs.sqlalchemy.org/en/20/changelog/migration_20.html#the-1-4-2-0-migration-path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, this is your first pull request in IoTDB project. Thanks for your contribution! IoTDB will be better because of you.
There are still some issues that require further modifications https://github.com/apache/iotdb/actions/runs/11910341559/job/33262355435?pr=14083 |
FYI, the reason why I can't run the tests locally is because I have the following error : |
Hi, thanks for your work. It seems that the CI with sqlalchemy 2.0 finally works. However, the tests with sqlalchemy 1.4 failed. Is there any way we can support both 1.4 and 2.0? |
Description
There are only a few breaking changes listed in https://docs.sqlalchemy.org/en/20/changelog/migration_20.html#the-1-4-2-0-migration-path, and not is impacting this project.
Closes #13991
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR