Unaligned tvlist feat #14265
Open
Unaligned tvlist feat #14265
+1,834
−614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shizy818
force-pushed
the
unaligned-tvlist-feat
branch
from
a9c5aab
to
215cb4b
Compare
shizy818
commented
Dec 2, 2024
| pageStatistics.setEmpty(false); | ||
| } | ||
| tvListOffsets = timeValuePairIterator.getTVListOffsets(); | ||
| cnt++; |
shizy818
commented
Dec 2, 2024
| } | ||
| } | ||
|
|
||
| private void InitializeOffsets() { |
shizy818
commented
Dec 2, 2024
| "TVList {} is released by the query, FragmentInstance Id is {}", | ||
| tvList, | ||
| this.getId()); | ||
| tvList.clear(); |
There was a problem hiding this comment.
这里应该调用memoryReservationManager.releaseMemoryCumulatively(tvList.calculateRamSize())释放查询内存
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Content1 ...
Content2 ...
Content3 ...
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR