Modify S3 endpoint regex pattern to support VPC endpoints. #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaul
requested changes
Jul 16, 2024
| @@ -26,7 +26,7 @@ | |||
|
|
|||
| public class AwsHostNameUtils { | |||
|
|
|||
| private static final Pattern S3_ENDPOINT_PATTERN = Pattern.compile("^(?:.+\\.)?s3[.-]([a-z0-9-]+)$"); | |||
| private static final Pattern S3_ENDPOINT_PATTERN = Pattern.compile("^(?:.+\\.)?s3[.\\-]([a-z0-9-]+)(?>\\.[a-z0-9-]+)*$"); | |||
There was a problem hiding this comment.
Can you add some kind of unit test which exercises this?
jcalcote
force-pushed
the
feature/master/support-aws-virtual-private-clouds
branch
from
01f05e2
to
022d25e
Compare
|
Thank you for your contribution @jcalcote! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Virtual private clouds are a relatively new feature of AWS. The jclouds AWS endpoint regex was not originally designed to be able to handle VPC formatted endpoints. This new expanded regex does the trick. The change also (incidentally) allows the regex to recognize both forms of basic s3 endpoints: s3-region and s3.region.