Remove etched borders.

[weisJ]

Description

Remove the usage of BorderFactory#createEtchedBorder.

Motivation and Context

Currently EtchedBorder is used for almost (but weirdly not all) titled borders.
They are undesirable for multiple reasons:

1. The Laf can't provide a custom etched border. Instead:
2. Etched borders simply use a lighter and darker version of the background colour, which most of the time looks out of place (especially with regards to "newer" design standards).

When using BorderFactory#createTitledBorder without specifying the border explicitly the a LaF-provided border is used. Because it can provide a border which looks good together with the rest of the LaF the result looks a lot more consistent.

At the places where simply BorderFactory#createEtchedBorder is used it is replaced by BorderFactory.createLineBorder("") which simply uses an unmodified version of the border provided by the laf.

How Has This Been Tested?

See screenshots. Only visuals are updated.

Screenshots (if appropriate):

All other lafs not shown look the same as before, because they use an EtchedBorder by default.

Before:

Metal

Nimbus

IntelliJ

After:

Metal

Nimbus

IntelliJ

Types of changes

• UI improvements.

Checklist:

• My code follows the code style of this project.
• I have updated the documentation accordingly. Not needed.

[vlsi]

@pmouawad , @FSchumacher , any idea here?

Frankly speaking, I'm inclined to merge this.

As you probably have seen, I've recently removed some of the borders, and I appreciate @weisJ taking time to unify the UI.

I don't quite like how Nimbus LaF defaults to LoweredBorder by default, however, that is their choice. I don't think JMeter should compensate that by adding explicit etched everywhere.

If one desires to use Nimbus, but keep borders etched rather than lowered, then we could probably add a property that would call uiDefaults.put("TitledBorder.border", ...); to augment the LaF in question.

[vlsi]

I did click through different components, and it looks good to me.