Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ops.html #365

Merged
merged 1 commit into from
May 5, 2023
Merged

Conversation

jaapterwoerds
Copy link
Contributor

No description provided.

@rbowen
Copy link

rbowen commented May 4, 2023

This patch replaces:

primary->secondary.enable

with

primary->secondary.enabled

in several places in ops.html.

LTGM.

@divijvaidya
Copy link
Contributor

Hey @jaapterwoerds
Thank you for the contributions and welcome to the Kafka community (I noticed that this is your first contribution!).

As you might already be aware, this bug has already been fixed in all versions released since late 2021, as part of apache/kafka#10433. The change you are submitting here is for documentation of version 2.8.
As part of our end of life policy, that is an unsupported version and we usually don't backport changes (documentation or otherwise) to the unsupported versions.

Having said that, since this is your first commit to our community, I will request the reviewers to merge this change in.

(As an aside, it helps the reviewers if you add a motivation and the description of the change in the summary section)

Copy link
Contributor

@showuon showuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@showuon showuon merged commit be52df9 into apache:asf-site May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants