Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding documentation for KIP-614 #10051

Merged
merged 2 commits into from
Feb 24, 2021
Merged

Conversation

vamossagar12
Copy link
Contributor

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Copy link
Contributor

@cadonna cadonna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the docs, @vamossagar12!

You need to move the paragraph one section up.

docs/streams/upgrade-guide.html Outdated Show resolved Hide resolved
@vamossagar12
Copy link
Contributor Author

done.

Copy link
Contributor

@cadonna cadonna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vamossagar12, Thanks a lot!

LGTM!

@cadonna
Copy link
Contributor

cadonna commented Feb 5, 2021

@vamossagar12, you need to rebase your PR.

@cadonna
Copy link
Contributor

cadonna commented Feb 5, 2021

Call for committer review: @guozhangwang

@vamossagar12
Copy link
Contributor Author

vamossagar12 commented Feb 5, 2021

@cadonna Done.

Copy link
Contributor

@vvcephei vvcephei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @vamossagar12 !

@vvcephei
Copy link
Contributor

Fixed the merge conflict.

@vvcephei vvcephei merged commit 8bd0e21 into apache:trunk Feb 24, 2021
vvcephei pushed a commit that referenced this pull request Feb 24, 2021
Reviewers: Bruno Cadonna <bruno@confluent.io>, John Roesler <vvcephei@apache.org>
@vvcephei
Copy link
Contributor

Merged to 2.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants