KAFKA-12289: Adding test cases for prefix scan in InMemoryKeyValueStore #10052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
vamossagar12
force-pushed
the
KAFKA-12289
branch
from
d97df6f to
37b2deb
Compare
vamossagar12
commented
Feb 4, 2021
streams/src/test/java/org/apache/kafka/streams/state/internals/InMemoryKeyValueStoreTest.java
Outdated
Show resolved
Hide resolved
vamossagar12
force-pushed
the
KAFKA-12289
branch
from
37b2deb to
5fe57fe
Compare
|
@cadonna , As discussed, i have added the test cases by adding store with key as Bytes. Also, have added the warning with the example in the javadocs for prefixScan() |
vamossagar12
force-pushed
the
KAFKA-12289
branch
from
5fe57fe to
5dce8f2
Compare
cadonna
reviewed
Feb 24, 2021
streams/src/main/java/org/apache/kafka/streams/state/ReadOnlyKeyValueStore.java
Outdated
Show resolved
Hide resolved
streams/src/test/java/org/apache/kafka/streams/state/internals/InMemoryKeyValueStoreTest.java
Outdated
Show resolved
Hide resolved
…eyValueStore.java Co-authored-by: Bruno Cadonna <bruno@confluent.io>
…/InMemoryKeyValueStoreTest.java Co-authored-by: Bruno Cadonna <bruno@confluent.io>
|
Thanks @cadonna , i have committed your suggestions. |
cadonna
approved these changes
Feb 25, 2021
|
Call for committer approval: @guozhangwang @ableegoldman @mjsax @vvcephei @abbccdda |
|
LGTM. Thanks for the contribution @vamossagar12 ! |
guozhangwang
pushed a commit
that referenced
this pull request
Mar 2, 2021
…re (#10052) Co-authored-by: Bruno Cadonna <bruno@confluent.io> Reviewers: Bruno Cadonna <cadonna@confluent.io>, Guozhang Wang <guozhang@confluent.io>
|
Cherry-picked to 2.8 as well cc @vvcephei |
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
Mar 2, 2021
* apache-github/trunk: (37 commits) KAFKA-10357: Extract setup of changelog from Streams partition assignor (apache#10163) KAFKA-10251: increase timeout for consuming records (apache#10228) KAFKA-12394; Return `TOPIC_AUTHORIZATION_FAILED` in delete topic response if no describe permission (apache#10223) MINOR: Disable transactional/idempotent system tests for Raft quorums (apache#10224) KAFKA-10766: Unit test cases for RocksDBRangeIterator (apache#9717) KAFKA-12289: Adding test cases for prefix scan in InMemoryKeyValueStore (apache#10052) KAFKA-12268: Implement task idling semantics via currentLag API (apache#10137) MINOR: Time and log producer state recovery phases (apache#10241) MINOR: correct the error message of validating uint32 (apache#10193) MINOR: Format the revoking active log output in `StreamsPartitionAssignor` (apache#10242) KAFKA-12323 Follow-up: Refactor the unit test a bit (apache#10205) MINOR: Remove stack trace of the lock exception in a debug log4j (apache#10231) MINOR: Word count should account for extra whitespaces between words (apache#10229) MINOR; Small refactor in `GroupMetadata` (apache#10236) KAFKA-10340: Proactively close producer when cancelling source tasks (apache#10016) KAFKA-12329; kafka-reassign-partitions command should give a better error message when a topic does not exist (apache#10141) KAFKA-12254: Ensure MM2 creates topics with source topic configs (apache#10217) MINOR: fix kafka-metadata-shell.sh (apache#10226) KAFKA-12374: Add missing config sasl.mechanism.controller.protocol (apache#10199) KAFKA-10101: Fix edge cases in Log.recoverLog and LogManager.loadLogs (apache#8812) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)