MINOR: Fix deprecation warnings in SlidingWindowedCogroupedKStreamImplTest #10703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijuma
changed the title
mjsax
reviewed
May 15, 2021
| @@ -156,7 +156,7 @@ public void slidingWindowAggregateStreamsTest() { | |||
| final TestInputTopic<String, String> testInputTopic = driver.createInputTopic( | |||
| TOPIC, new StringSerializer(), new StringSerializer()); | |||
| final TestOutputTopic<Windowed<String>, String> testOutputTopic = driver.createOutputTopic( | |||
| OUTPUT, new TimeWindowedDeserializer<>(new StringDeserializer()), new StringDeserializer()); | |||
| OUTPUT, new TimeWindowedDeserializer<>(new StringDeserializer(), Long.MAX_VALUE), new StringDeserializer()); | |||
There was a problem hiding this comment.
Seems we setup the window with 500ms:
SlidingWindows.withTimeDifferenceAndGrace(ofMillis(500L),...)
Thus we should pass in the same value instead of MAX_VAVLUE.
We should also change TestRecord<String,String> below to TestRecorded<Windowed<String>,String>
There was a problem hiding this comment.
I've changed the code to pass 500L, but the TestRecord change causes compilation errors since we explicitly use a nonWindowedRecord:
results.add(nonWindowedRecord);
Can we address that separately? I think we can focus on fixing the deprecation warning in this PR, if that's ok with you.
| @@ -212,7 +212,7 @@ public void slidingWindowAggregateOverlappingWindowsTest() { | |||
| final TestInputTopic<String, String> testInputTopic = driver.createInputTopic( | |||
| TOPIC, new StringSerializer(), new StringSerializer()); | |||
| final TestOutputTopic<Windowed<String>, String> testOutputTopic = driver.createOutputTopic( | |||
| OUTPUT, new TimeWindowedDeserializer<>(new StringDeserializer()), new StringDeserializer()); | |||
| OUTPUT, new TimeWindowedDeserializer<>(new StringDeserializer(), Long.MAX_VALUE), new StringDeserializer()); | |||
|
Thanks. Did a follow up PR: #10745 |
3 tasks
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
May 26, 2021
…e-allocations-lz4 * apache-github/trunk: (43 commits) KAFKA-12800: Configure generator to fail on trailing JSON tokens (apache#10717) MINOR: clarify message ordering with max in-flight requests and idempotent producer (apache#10690) MINOR: Add log identifier/prefix printing in Log layer static functions (apache#10742) MINOR: update java doc for deprecated methods (apache#10722) MINOR: Fix deprecation warnings in SlidingWindowedCogroupedKStreamImplTest (apache#10703) KAFKA-12499: add transaction timeout verification (apache#10482) KAFKA-12620 Allocate producer ids on the controller (apache#10504) MINOR: Kafka Streams code samples formating unification (apache#10651) KAFKA-12808: Remove Deprecated Methods under StreamsMetrics (apache#10724) KAFKA-12522: Cast SMT should allow null value records to pass through (apache#10375) KAFKA-12820: Upgrade maven-artifact dependency to resolve CVE-2021-26291 HOTFIX: fix checkstyle issue in KAFKA-12697 KAFKA-12697: Add OfflinePartitionCount and PreferredReplicaImbalanceCount metrics to Quorum Controller (apache#10572) KAFKA-12342: Remove MetaLogShim and use RaftClient directly (apache#10705) KAFKA-12779: KIP-740, Clean up public API in TaskId and fix TaskMetadata#taskId() (apache#10735) KAFKA-12814: Remove Deprecated Method StreamsConfig getConsumerConfigs (apache#10737) MINOR: Eliminate redundant functions in LogTest suite (apache#10732) MINOR: Remove unused maxProducerIdExpirationMs parameter in Log constructor (apache#10723) MINOR: Updating files with release 2.7.1 (apache#10660) KAFKA-12809: Remove deprecated methods of Stores factory (apache#10729) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Checklist (excluded from commit message)