Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Note that slf4j-log4j in version 1.7.35+ should be used #12114

Merged
merged 2 commits into from
May 3, 2022
Merged

MINOR: Note that slf4j-log4j in version 1.7.35+ should be used #12114

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed74596
MINOR: Note that slf4j-log4j in version 1.7.35+ should be used
cadonna May 2, 2022
43235cf
Include feedback
cadonna May 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion docs/upgrade.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,13 @@ <h5><a id="upgrade_320_notable" href="#upgrade_320_notable">Notable changes in 3
via Connect worker and/or connector configuration. Connect may enable idempotent producers
by default in a future major release.</li>
<li>Kafka has replaced log4j and slf4j-log4j12 with reload4j and slf4j-reload4j due to security concerns.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can say something like:

    <li>Kafka has replaced log4j and slf4j-log4j12 with reload4j and slf4j-reload4j due to security concerns.
         This only affects modules that specify a logging backend (`connect-runtime` and `kafka-tools` are two such
         examples). A number of modules, including `kafka-clients`, leave it to the application to specify the logging
         backend. More information can be found at <a href"https://reload4j.qos.ch">reload4j</a>.
        Projects that depend on the affected modules from the Kafka project should use
        <a href="https://www.slf4j.org/manual.html#swapping">slf4j-log4j12 version 1.7.35 or above</a> or
        slf4j-reload4j to avoid
        <a href="https://www.slf4j.org/codes.html#no_tlm">possible compatibility issues originating from the logging framework</a>.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update the same text in the 3.1 branch once we merge this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ijuma changed the text as you proposed.

I will cherry-pick the commit to 3.2 and 3.1.

@tombentley Since this is just a doc change, we do not need a new RC, right? We can port the change directly to the doc repo in case RC1 passes the votes.

More information can be found at <a href"https://reload4j.qos.ch">reload4j</a>.</li>
This only affects modules that specify a logging backend (<code>connect-runtime</code> and <code>kafka-tools</code> are two such examples).
A number of modules, including <code>kafka-clients</code>, leave it to the application to specify the logging backend.
More information can be found at <a href"https://reload4j.qos.ch">reload4j</a>.
Projects that depend on the affected modules from the Kafka project should use
<a href="https://www.slf4j.org/manual.html#swapping">slf4j-log4j12 version 1.7.35 or above</a> or
slf4j-reload4j to avoid
<a href="https://www.slf4j.org/codes.html#no_tlm">possible compatibility issues originating from the logging framework</a>.</li>
<li>The example connectors, <code>FileStreamSourceConnector</code> and <code>FileStreamSinkConnector</code>, have been
removed from the default classpath. To use them in Kafka Connect standalone or distributed mode they need to be
explicitly added, for example <code>CLASSPATH=./lib/connect-file-3.2.0.jar ./bin/connect-distributed.sh</code>.</li>
Expand Down