KAFKA-15705: Add integration tests for Heartbeat API and GroupLeave API #14656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongnuo123
commented
Oct 27, 2023
core/src/test/scala/unit/kafka/server/LeaveGroupRequestTest.scala
Outdated
Show resolved
Hide resolved
dongnuo123
commented
Oct 27, 2023
dajac
reviewed
Nov 16, 2023
core/src/test/scala/unit/kafka/server/HeartbeatRequestTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/unit/kafka/server/HeartbeatRequestTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/unit/kafka/server/LeaveGroupRequestTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/unit/kafka/server/LeaveGroupRequestTest.scala
Outdated
Show resolved
Hide resolved
3 tasks
dajac
reviewed
Nov 20, 2023
There was a problem hiding this comment.
@dongnuo123 Thanks for the update. I left two small comments.
core/src/test/scala/unit/kafka/server/HeartbeatRequestTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala
Outdated
Show resolved
Hide resolved
dajac
reviewed
Nov 20, 2023
dajac
reviewed
Nov 20, 2023
core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala
Outdated
Show resolved
Hide resolved
dajac
reviewed
Nov 20, 2023
Comment on lines
+156
to
+159
| TestUtils.waitUntilTrue(() => { | ||
| val described = describeGroups(groupIds = List("grp"), version = ApiKeys.DESCRIBE_GROUPS.latestVersion(isUnstableApiEnabled)) | ||
| GenericGroupState.PREPARING_REBALANCE.toString == described.head.groupState | ||
| }, msg = s"The group is not in PREPARING_REBALANCE state.") |
There was a problem hiding this comment.
I wonder if we should just remove this and wrap the next HB in waitUntilTrue. Have you considered it?
There was a problem hiding this comment.
It doesn't work because somehow the code in the previous future tend to be executed later than the following code, so I have to set a waitUntilTrue or sleep for a while to make sure the request in the future is processed first.
yyu1993
pushed a commit
to yyu1993/kafka
that referenced
this pull request
Feb 15, 2024
…PI (apache#14656) Reviewers: David Jacot <djacot@confluent.io>
AnatolyPopov
pushed a commit
to aiven/kafka
that referenced
this pull request
Feb 16, 2024
…PI (apache#14656) Reviewers: David Jacot <djacot@confluent.io>
clolov
pushed a commit
to clolov/kafka
that referenced
this pull request
Apr 5, 2024
…PI (apache#14656) Reviewers: David Jacot <djacot@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is based on #14589,
Adding integration tests for Heartbeat API and GroupLeave API.
JIRA
https://issues.apache.org/jira/browse/KAFKA-15705
Committer Checklist (excluded from commit message)