-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-10787: Apply spotless to metadata
and server
and storage
module
#16297
Merged
chia7712
merged 7 commits into
apache:trunk
from
gongxuanzhang:apply-metadata-storage-server
Jun 15, 2024
Merged
KAFKA-10787: Apply spotless to metadata
and server
and storage
module
#16297
chia7712
merged 7 commits into
apache:trunk
from
gongxuanzhang:apply-metadata-storage-server
Jun 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 12, 2024
@gongxuanzhang please add spotlessJava.dependsOn 'processMessages' to the module having processMessages task. Otherwise, spotless may ignore those generated code |
@gongxuanzhang please fix the conflicts |
@gongxuanzhang could you please fix the conflicts? |
chia7712
approved these changes
Jun 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Jun 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is sub PR from #16097.
It is part of a series of changes to progressively apply [spotless plugin(import-order)] across all modules. In this step, the plugin is activated in the
Module and history
Module and history
How to test:
We can run
./gradlew spotlessCheck
check for code that does not meet requirements.If we get report that error , we can run
./gradlew spotlessApply
to review my code.In this PR, all change(exclude
build.gradle
)by
spotlessApply`