Set rocksdb.share_metadata_and_subkey_block_cache to yes by default (#…

…373)
apache · Nov 2, 2021 · 1e47739 · 1e47739
1 parent ea4bf04
commit 1e47739
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/kvrocks.conf b/kvrocks.conf
@@ -332,8 +332,8 @@ rocksdb.subkey_block_cache_size 2048
 # if set 'yes'. The capacity of shared block cache is
 # metadata_block_cache_size + subkey_block_cache_size
 #
-# Default: no
-rocksdb.share_metadata_and_subkey_block_cache no
+# Default: yes
+rocksdb.share_metadata_and_subkey_block_cache yes
 
 # Number of open files that can be used by the DB.  You may need to
 # increase this if your database has a large working set. Value -1 means

diff --git a/src/config.cc b/src/config.cc
@@ -123,7 +123,7 @@ Config::Config() {
       {"rocksdb.subkey_block_cache_size", true, new IntField(&RocksDB.subkey_block_cache_size, 2048, 0, INT_MAX)},
       {"rocksdb.metadata_block_cache_size", true, new IntField(&RocksDB.metadata_block_cache_size, 2048, 0, INT_MAX)},
       {"rocksdb.share_metadata_and_subkey_block_cache",
-       true, new YesNoField(&RocksDB.share_metadata_and_subkey_block_cache, false)},
+       true, new YesNoField(&RocksDB.share_metadata_and_subkey_block_cache, true)},
       {"rocksdb.compaction_readahead_size", false, new IntField(&RocksDB.compaction_readahead_size, 2*MiB, 0, 64*MiB)},
       {"rocksdb.level0_slowdown_writes_trigger",
        false, new IntField(&RocksDB.level0_slowdown_writes_trigger, 20, 1, 1024)},