Skip to content

Commit

Permalink
Remove debug server logs
Browse files Browse the repository at this point in the history
These logs were there in the earliest days, i guess
they are for debug, remove them now to avoid polluting
the server logs.

The blpop one is easy to reproduce:
```
Failed to execute redis command: blpop, err: Invalid argument: WRONGTYPE
Operation against a key holding the wrong kind of value
```

Checked the relevant LOG calls and fix a typo.
  • Loading branch information
enjoy-binbin committed Jul 6, 2023
1 parent 7e23c0b commit ee4dc70
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 5 deletions.
2 changes: 1 addition & 1 deletion src/cluster/replication.cc
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ void FeedSlaveThread::loop() {
auto batch = iter_->GetBatch();
if (batch.sequence != curr_seq) {
LOG(ERROR) << "Fatal error encountered, WAL iterator is discrete, some seq might be lost"
<< ", sequence " << curr_seq << " expectd, but got " << batch.sequence;
<< ", sequence " << curr_seq << " expected, but got " << batch.sequence;
Stop();
return;
}
Expand Down
2 changes: 0 additions & 2 deletions src/commands/cmd_list.cc
Original file line number Diff line number Diff line change
Expand Up @@ -234,8 +234,6 @@ class CommandBPop : public Commander,
}
} else if (!s.IsNotFound()) {
conn_->Reply(redis::Error("ERR " + s.ToString()));
LOG(ERROR) << "Failed to execute redis command: " << conn_->current_cmd->GetAttributes()->name
<< ", err: " << s.ToString();
}

return s;
Expand Down
2 changes: 0 additions & 2 deletions src/commands/cmd_stream.cc
Original file line number Diff line number Diff line change
Expand Up @@ -742,8 +742,6 @@ class CommandXRead : public Commander,
auto s = stream_db.Range(streams_[i], options, &result);
if (!s.ok()) {
conn_->Reply(redis::MultiLen(-1));
LOG(ERROR) << "ERR executing XRANGE for stream " << streams_[i] << " from " << ids_[i].ToString() << " to "
<< options.end.ToString() << " with count " << count_ << ": " << s.ToString();
}

if (result.size() > 0) {
Expand Down

0 comments on commit ee4dc70

Please sign in to comment.