Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support slot batch operation for CLUSTERX SETSLOT (REVIVED) #1412

Closed
1 of 2 tasks
PragmaTwice opened this issue Apr 29, 2023 · 0 comments · Fixed by #1414
Closed
1 of 2 tasks

Support slot batch operation for CLUSTERX SETSLOT (REVIVED) #1412

PragmaTwice opened this issue Apr 29, 2023 · 0 comments · Fixed by #1414
Labels
enhancement type enhancement help wanted Good for newcomers

Comments

@PragmaTwice
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar issues.

Motivation

Since it seems important to support slot batch operation for CLUSTERX SETSLOT, we want to revive this abandoned PR #529.

From #529:

Support for #510

It is an enhancement to the original implement of command CLUSTERX SETSLOT #463

Command formart

CLUSTERX SETSLOT "$slot_batch" NODE $node_id $new_version

assign batch slots to the node if new version is current version+1.
It is compatible with the original command syntax.

Parameter Changes

$slot_batch: batch slots which we want to assign. It can be given by single slotid or slot batch. Slot batch can be given by continuous slot range or discrete slot list with spaces as separators, e.g. "3 5 9 10-20".

Example
CLUSTERX SETSLOT 1 NODE $nodeid1 1
CLUSTERX SETSLOT "3 5 9 20-30" NODE $nodeid1 2

Solution

See #529

Are you willing to submit a PR?

  • I'm willing to submit a PR!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement type enhancement help wanted Good for newcomers
Projects
Development

Successfully merging a pull request may close this issue.

1 participant