Support slot batch operation for CLUSTERX SETSLOT #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChrisZMF you may separate the fix typo part into a dedicated patch and resolve the conflict so that we can continue reviewing this patch :) |
|
Closed as inactive. You may resubmit the patch base on the latest unstable branch. |
2 tasks
2 tasks
infdahai
added a commit
to infdahai/incubator-kvrocks
that referenced
this pull request
May 1, 2023
Signed-off-by: clundro <859287553@qq.com>
infdahai
added a commit
to infdahai/incubator-kvrocks
that referenced
this pull request
May 3, 2023
Signed-off-by: clundro <859287553@qq.com>
infdahai
added a commit
to infdahai/incubator-kvrocks
that referenced
this pull request
May 3, 2023
ref(https://godbolt.org/z/5q6zj5W9s) Signed-off-by: clundro <859287553@qq.com> add cluster_slot_batch ref to apache#529 Signed-off-by: clundro <859287553@qq.com> add tests for parsedSlotRange Signed-off-by: clundro <859287553@qq.com>
infdahai
added a commit
to infdahai/incubator-kvrocks
that referenced
this pull request
May 3, 2023
ref(https://godbolt.org/z/5q6zj5W9s) Signed-off-by: clundro <859287553@qq.com> add cluster_slot_batch ref to apache#529 Signed-off-by: clundro <859287553@qq.com> add tests for parsedSlotRange Signed-off-by: clundro <859287553@qq.com>
infdahai
added a commit
to infdahai/incubator-kvrocks
that referenced
this pull request
May 4, 2023
1. add cluster_slot_batch ref to apache#529 2. add tests for parsedSlotRange 3. move parse func to commandX Signed-off-by: clundro <859287553@qq.com>
infdahai
added a commit
to infdahai/incubator-kvrocks
that referenced
this pull request
May 4, 2023
1. add cluster_slot_batch ref to apache#529 2. add tests for parsedSlotRange 3. move parse func to commandX Signed-off-by: clundro <859287553@qq.com>
infdahai
added a commit
to infdahai/incubator-kvrocks
that referenced
this pull request
May 5, 2023
1. add cluster_slot_batch ref to apache#529 2. add tests for parsedSlotRange 3. move parse func to commandX # Signed-off-by: clundro <859287553@qq.com> Signed-off-by: clundro <859287553@qq.com>
infdahai
added a commit
to infdahai/incubator-kvrocks
that referenced
this pull request
May 5, 2023
1. add cluster_slot_batch ref to apache#529 2. add tests for parsedSlotRange 3. move parse func to commandX Signed-off-by: clundro <859287553@qq.com>
infdahai
added a commit
to infdahai/incubator-kvrocks
that referenced
this pull request
May 14, 2023
1. add cluster_slot_batch ref to apache#529 2. add tests for parsedSlotRange 3. move parse func to commandX Signed-off-by: clundro <859287553@qq.com>
infdahai
added a commit
to infdahai/incubator-kvrocks
that referenced
this pull request
May 14, 2023
1. add cluster_slot_batch ref to apache#529 2. add tests for parsedSlotRange 3. move parse func to commandX Signed-off-by: clundro <859287553@qq.com>
infdahai
added a commit
to infdahai/incubator-kvrocks
that referenced
this pull request
May 14, 2023
1. add cluster_slot_batch ref to apache#529 2. add tests for parsedSlotRange 3. move parse func to commandX Signed-off-by: clundro <859287553@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for #510
It is an enhancement to the original implement of command
CLUSTERX SETSLOT#463Command formart
CLUSTERX SETSLOT "$slot_batch" NODE $node_id $new_versionassign batch slots to the node if new version is current version+1.
It is compatible with the original command syntax.
Parameter Changes
Example
CLUSTERX SETSLOT 1 NODE $nodeid1 1CLUSTERX SETSLOT "3 5 9 20-30" NODE $nodeid1 2