Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version information for each command to the Supported Commands page in website #1929

Closed
1 of 2 tasks
PragmaTwice opened this issue Dec 9, 2023 · 5 comments
Closed
1 of 2 tasks
Assignees
Labels
enhancement type enhancement good first issue Good for newcomers help wanted Good for newcomers

Comments

@PragmaTwice
Copy link
Member

PragmaTwice commented Dec 9, 2023

Search before asking

  • I had searched in the issues and found no similar issues.

Motivation

https://kvrocks.apache.org/docs/supported-commands

We'd better to add which version each command started to be supported, e.g.

Command Since Version
FCALL 2.7.0

Solution

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@PragmaTwice PragmaTwice added enhancement type enhancement help wanted Good for newcomers good first issue Good for newcomers labels Dec 9, 2023
@tisonkun
Copy link
Member

tisonkun commented Dec 9, 2023

This may not be a good first issue but actually the contributor should know detail about the command impl history :D

@jihuayu
Copy link
Member

jihuayu commented Dec 11, 2023

Contributors can write a string matching program to check if each command exists in a specific version of the source code.
So I think the contributor don't need to know detail about the command impl history

@kay011
Copy link
Contributor

kay011 commented Dec 17, 2023

Hello, can you assign this issue to me?

@git-hulk
Copy link
Member

@kay011 Thank you! As @jihuayu mentioned, maybe a quick way is to write a program to detect the support commands in each version.

@kay011
Copy link
Contributor

kay011 commented Dec 18, 2023

@git-hulk Yeah!I plan to check the commands supported by each version through Python regular expressions. I will submit this script file and the final markdown file. This should be quick. Just paste the final results on the final docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement type enhancement good first issue Good for newcomers help wanted Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants