BITCOUNT return wrong when args > 4

[jihuayu]

Search before asking

• I had searched in the issues and found no similar issues.

Version

unstable

Minimal reproduce step

127.0.0.1:6666> SET mykey "foobar"
OK
127.0.0.1:6666> BITCOUNT mykey 5 30
(integer) 4
127.0.0.1:6666> BITCOUNT mykey 5 30 111
(integer) 26

What did you expect to see?

BITCOUNT mykey 5 30 111 return 4

What did you see instead?

BITCOUNT mykey 5 30 111 return ERROR

Anything Else?

kvrocks/src/commands/cmd_bit.cc

Lines 94 to 117 in 574d438

	class CommandBitCount : public Commander {
	public:
	Status Parse(const std::vector<std::string> &args) override {
	if (args.size() == 3) {
	return {Status::RedisParseErr, errInvalidSyntax};
	}
	if (args.size() == 4) {
	auto parse_start = ParseInt<int64_t>(args[2], 10);
	if (!parse_start) {
	return {Status::RedisParseErr, errValueNotInteger};
	}
	start_ = *parse_start;
	auto parse_stop = ParseInt<int64_t>(args[3], 10);
	if (!parse_stop) {
	return {Status::RedisParseErr, errValueNotInteger};
	}
	stop_ = *parse_stop;
	}
	return Commander::Parse(args);
	}

We need return ERROR when args.size() > 4

Are you willing to submit a PR?

• I'm willing to submit a PR!

[tisonkun]

Below is how Redis works:

127.0.0.1:6379> SET mykey "foobar"
OK
127.0.0.1:6379>  BITCOUNT mykey 5 30
(integer) 4
127.0.0.1:6379>  BITCOUNT mykey 5 30 111
(error) ERR syntax error

@jihuayu would you like to fix it? Or I can take a look.

[jihuayu]

@tisonkun Go ahead. Thank you!
I will not fix it