Fix parse BITCOUNT #1979
Merged
Fix parse BITCOUNT #1979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
commented
Jan 3, 2024
| @@ -113,6 +118,15 @@ class CommandBitCount : public Commander { | |||
| stop_ = *parse_stop; | |||
| } | |||
|
|
|||
| if (args.size() == 5) { | |||
| if (util::EqualICase(args[4], "BYTE")) { | |||
| } else if (util::EqualICase(args[4], "BIT")) { | |||
There was a problem hiding this comment.
BIT modifier is supported in Redis 7.0.
But we assume counting in bytes everywhere so it's non-trivial to implement. It can be a follow-up issue.
There was a problem hiding this comment.
|
The patch is trivial and it's not worthy to add a test case .. |
|
git-hulk
approved these changes
Jan 3, 2024
PragmaTwice
approved these changes
Jan 3, 2024
mapleFU
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1978 .