Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Unable to build. #225

Closed
shanemarsh28 opened this issue Apr 20, 2021 · 3 comments · Fixed by #226
Closed

[BUG] Unable to build. #225

shanemarsh28 opened this issue Apr 20, 2021 · 3 comments · Fixed by #226
Assignees
Labels
bug type bug

Comments

@shanemarsh28
Copy link

shanemarsh28 commented Apr 20, 2021

Attempting to compile as per instructions on Readme. Unable to build.

image

./db/version_edit.h:86:8: error: implicitly-declared ‘constexpr rocksdb::FileDescriptor::FileDescriptor(const rocksdb::FileDescriptor&)’ is deprecated [-Werror=deprecated-copy]

  • OS: Ubuntu 20.04
  • GCC/G++ (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0
  • GNU Make 4.2.1

To Reproduce
Steps to reproduce the behavior:

  1. Build as per instructions on README
@shanemarsh28
Copy link
Author

Just an as update, it wouldn't compile under GCC 10.2.0 either but I did have success using GCC 8.4.0.

Perhaps add that as a requirement within your Readme.md?

image

@git-hulk
Copy link
Member

git-hulk commented Apr 21, 2021

many thanks to @shanemarsh28 to find out about this issue, it seems rocksdb doesn't support higher version GCC(>=9) and fixed in newer, we would also fix that. any progress would update in this channel.

relate issue: facebook/rocksdb#5303

@git-hulk git-hulk added the bug type bug label Apr 21, 2021
@git-hulk
Copy link
Member

We have confirmed that the newer version(after 6.15.1) of rocksdb has compatible with gcc9 in ubuntu20.04. @karelrooted would help to investigate whether the newer version has other issues within kvrocks, and we would upgrade the rocksdb dependence to the latest if all works well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug type bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants