Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rocksdb to latest tag v6.19.3 #226

Conversation

karelrooted
Copy link
Contributor

@karelrooted karelrooted commented Apr 21, 2021

Fix can't compile on GCC(>=9) (resolves #225 rocksdb fix this at PR facebook/rocksdb#5553)
Fix can't auto resume after no space error (rocksdb add the auto resume feature at PR facebook/rocksdb#6765)

@karelrooted
Copy link
Contributor Author

karelrooted commented Apr 21, 2021

Successly compile on Docker centos 8.2 ( gcc 8.3.1), Docker ubuntu 20.04 (gcc 9.3.0), Mac OS 10.15.7 (cmake)

Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karelrooted karelrooted changed the title Upgrade rocksdb to newest tag v6.19.3 Upgrade rocksdb to latest tag v6.19.3 Apr 21, 2021
@ShooterIT
Copy link
Member

cool, so now rocksdb is latest release

@karelrooted karelrooted merged commit 4cf6a9a into apache:unstable Apr 21, 2021
@karelrooted karelrooted deleted the enhancement/upgrade-rocksdb-to-latest-tag-v6.19.3 branch April 21, 2021 06:06
@ShooterIT ShooterIT mentioned this pull request Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Unable to build.
3 participants