-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split redis_cmd.cc to multiple files by category #1244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, love this pr.
Isn't the |
I am considering |
Though, the current one is acceptable for me. |
How about dropping the prefix? |
I think the prefix can make them more distinguishing than other source files (in this dir) in alphabetical order, e.g.
than
|
@caipengbo @Hulk I did some rename in cd17abf:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PragmaTwice Great job!
Thanks all. Merging... |
It closes #1138.
Current file structure in
src/commands
: