Improve code style and do some minor fix in scripting #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torwig
previously approved these changes
Mar 10, 2023
PragmaTwice
commented
Mar 10, 2023
Comment on lines
-112
to
+116
| if (read_only) { | ||
| /* redis.read_only */ | ||
| lua_pushstring(lua, "read_only"); | ||
| lua_pushboolean(lua, 1); | ||
| lua_settable(lua, -3); | ||
| } | ||
| /* redis.read_only */ | ||
| lua_pushstring(lua, "read_only"); | ||
| lua_pushboolean(lua, read_only); | ||
| lua_settable(lua, -3); |
There was a problem hiding this comment.
It is not intuitionistic if the boolean value only exists when read_only is true
PragmaTwice
commented
Mar 10, 2023
Comment on lines
-183
to
-185
| if (level < GetServer()->GetConfig()->log_level) { | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
This level cannot be compared with loglevel in config.
PragmaTwice
commented
Mar 10, 2023
src/storage/scripting.cc
Outdated
| auto redisCmd = cmd_iter->second; | ||
| if (read_only && redisCmd->is_write()) { | ||
| if (read_only && ~(redisCmd->flags & Redis::kCmdReadOnly)) { |
There was a problem hiding this comment.
There is no assumption that a command is read-only if it has no write flag
PragmaTwice
commented
Mar 10, 2023
| std::string sha; | ||
| auto s = createFunction(srv, body, &sha, lua); | ||
| auto s = createFunction(srv, body, &sha, lua, false); |
There was a problem hiding this comment.
We do not need to store the script body here.
git-hulk
previously approved these changes
Mar 10, 2023
torwig
previously approved these changes
Mar 10, 2023
git-hulk
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to almost all functions in scripting.