Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Systemd service file update #1360

Merged
merged 3 commits into from
Mar 30, 2023
Merged

Systemd service file update #1360

merged 3 commits into from
Mar 30, 2023

Conversation

aleksraiden
Copy link
Contributor

A little bit updates, inspired from redis, nginx and mysql service unit definition.

  • KVRocks start requirement network-online instead of simple network policy
  • Starting a server only after network are fully up
  • Change maximum threads allowed (LimitNPROC) to 4096
  • Add timeout by 300 sec for start/stop service
  • Addition security setup with flag NoNewPrivileges

@aleksraiden
Update kvrocks.service
99c5944 
Change startup requirements to network-online
@aleksraiden
Update kvrocks.service
e1b3470 
Updates
@aleksraiden
Update kvrocks.service
867a8c9 
Fix
@aleksraiden aleksraiden changed the title Little systemd service file update Systemd service file update Mar 29, 2023
@torwig torwig requested review from git-hulk and PragmaTwice March 29, 2023 15:13
torwig
torwig approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@torwig torwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tisonkun
tisonkun approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go :)

Thanks for your contribution!

@tisonkun
Copy link
Member

Random thoughts - such service config can work better if integrated with package manager like AUR (pacman) or Homebrew.

@tisonkun
Copy link
Member

Merging...

@tisonkun tisonkun merged commit 3289bc7 into apache:unstable Mar 30, 2023
@aleksraiden aleksraiden deleted the systemd-service-patch-01 branch February 13, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@torwig torwig torwig approved these changes

@git-hulk git-hulk git-hulk approved these changes

@PragmaTwice PragmaTwice Awaiting requested review from PragmaTwice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aleksraiden @tisonkun @git-hulk @torwig