Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove manual code concat in scripting #1362

Merged
merged 2 commits into from
Mar 31, 2023
Merged

Remove manual code concat in scripting #1362

merged 2 commits into from
Mar 31, 2023

Conversation

PragmaTwice
Copy link
Member

No description provided.

@PragmaTwice PragmaTwice requested a review from git-hulk March 31, 2023 08:18
git-hulk
git-hulk previously approved these changes Mar 31, 2023
View reviewed changes
torwig
torwig previously approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@torwig torwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PragmaTwice PragmaTwice dismissed stale reviews from torwig and git-hulk via 27c5f6c March 31, 2023 13:07
@PragmaTwice PragmaTwice requested review from git-hulk and torwig March 31, 2023 13:16
@PragmaTwice PragmaTwice merged commit 54daf8d into apache:unstable Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torwig torwig torwig approved these changes

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PragmaTwice @git-hulk @torwig