-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support RocksDB auto-tune rate limiter for the background IO #1424
Conversation
To make the CI pass, you can run |
@xiaobiaozhao please benchmark this in |
This LGTM. Let wait some benchmarking for it |
I think you can reuse this configuration 'max-io-mb'. If it is 0 use auto-tune. |
|
Co-authored-by: Twice <twice@apache.org>
@xiaobiaozhao Did you test this PR? |
|
Press data into kvrocks script
write script
|
Thanks! Do you have idea that why the performance decline in normal p100(And does all performance optimization and decline comes from unstable test result)? |
I think this is bias of a test, p99 p9999 should be more convincing |
This option may bring better performance benefits when the background compaction is heavy, not sure if the benchmark data was under this scenario. But anyway, it's good to merge since it also brings slight performance improvement. |
Thanks all, merging... |
fix #1417