Bump fmtlib to 10.0.0 #1435
Merged
Bump fmtlib to 10.0.0 #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hulk
previously approved these changes
May 10, 2023
torwig
previously approved these changes
May 10, 2023
|
There seems some compile error while using fmt 10 in CI. Could you try to investigate it? Or you can wait me for some free time to handle it (maybe next week). |
|
A lot of thanks @torwig about fix issue |
|
This test case failure didn't relate to the current PR: https://github.com/apache/incubator-kvrocks/actions/runs/4957567221/jobs/8869740176?pr=1435 I am investigating now, won't block this PR to be merged |
git-hulk
approved these changes
May 12, 2023
|
@aleksraiden Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump fmtlib to 10.0.0. Full release desc - https://github.com/fmtlib/fmt/releases/tag/10.0.0
In this release: